Skip to content
This repository has been archived by the owner on Jan 3, 2023. It is now read-only.

[SQL-DS-CACHE-14][POAE7-847] Port HCFS to OAP #13

Merged
merged 14 commits into from
Feb 20, 2021
Merged

[SQL-DS-CACHE-14][POAE7-847] Port HCFS to OAP #13

merged 14 commits into from
Feb 20, 2021

Conversation

xieqi
Copy link
Contributor

@xieqi xieqi commented Feb 10, 2021

What changes were proposed in this pull request?

Add HCFS module

How was this patch tested?

UT

@github-actions
Copy link

Thanks for opening a pull request!

Could you open an issue for this pull request on Github Issues?
https://github.com/oap-project/sql-ds-cache/issues

Then could you also rename pull request title and commit log in the following format?

[SQL-DS-CACHE-${ISSUES_ID}] ${detailed message}

See also:

@winningsix
Copy link

A OAP issue needs to be created to make PR checker happy.

@xieqi xieqi changed the title [POAE7-847]Port HCFS to OAP [SQL-DS-CACHE-14][POAE7-847] Port HCFS to OAP Feb 10, 2021
@github-actions
Copy link

#14

@winningsix
Copy link

Thanks @xieqi for quick updates. A few comments:

  1. Let's have a separated module here. We should try best to isolate Spark dependency for HCFS module.
  2. A few follow-up PRs are needed like documentation,

@winningsix
Copy link

@xieqi let's make this two steps: 1. refactor original code to make it a sub-module; 2. merge HCFS implementation into this repo.

@xieqi
Copy link
Contributor Author

xieqi commented Feb 20, 2021

@winningsix rebased and include the Yu's latest optimization.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants